Skip to content

Add Geny to the community build #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

Add Geny to the community build #8862

merged 1 commit into from
May 6, 2020

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@anatoliykmetyuk anatoliykmetyuk self-assigned this May 1, 2020
@nicolasstucki
Copy link
Contributor

It is ok as it is. But we really need to not place the QuoteContext in fields. This should be considered an antipattern as we lose the contextual-ness of the QuoteContext. This pattern breaks within every splice where an new QuoteContext is provided but the relation with the wrapper is lost.

@anatoliykmetyuk anatoliykmetyuk merged commit 9c571d7 into scala:master May 6, 2020
@anatoliykmetyuk anatoliykmetyuk deleted the geny-cb branch May 6, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anatoliykmetyuk @nicolasstucki